feat: add draggable file upload component #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4nalog
changed the title
Signed-off-by: 4nalog <[email protected]>
Signed-off-by: 4nalog <[email protected]>
Signed-off-by: 4nalog <[email protected]>
4nalog
force-pushed
the
soham/draggable-file-upload-component
branch
from
7a7dd60 to
f8b8dee
Compare
Signed-off-by: 4nalog <[email protected]>
ursucarina
reviewed
Feb 22, 2023
packages/console/src/components/common/FileUpload/FileUpload.tsx
Outdated
Show resolved
Hide resolved
packages/console/src/components/common/FileUpload/FileUpload.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: 4nalog <[email protected]>
Signed-off-by: 4nalog <[email protected]>
ursucarina
approved these changes
Feb 24, 2023
jsonporter
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR implements a generic file upload component with support for dragging/dropping to upload.
Demo
Screen.Recording.2023-02-22.at.9.05.28.PM.mov
Type
Are all requirements met?
Complete description
This PR:
DraggableFileUploadcomponent to support uploading files with drag and drop functionalityTracking Issue
#3317
Follow-up issue
flyteorg/flyte#3317