Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error on invalid nested json input #693

Merged
merged 35 commits into from
Mar 30, 2023
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
303562a
fix: type error on invalid nested json input
4nalog Mar 1, 2023
4a16973
LaunchForm RJSF Form issue (#692)
james-union Mar 2, 2023
0636f14
chore: bump minor version
4nalog Mar 2, 2023
0aa8077
fix: package version to 1.4.2 (#700)
jsonporter Mar 3, 2023
4d60595
fix: project settings dashbboard tests (#701)
4nalog Mar 3, 2023
91567cb
fix: upgrading node version to 18 (#703)
jsonporter Mar 4, 2023
00542c6
fix: revert node version (#704)
ursucarina Mar 6, 2023
dc32d0b
fix: deployment optimization (#706)
ursucarina Mar 6, 2023
b2a7529
fix: upgrade release node version (#707)
ursucarina Mar 6, 2023
30c6c7f
fix: update chalk, add semantic-release test cmd (#708)
ursucarina Mar 7, 2023
ed495bb
chore: implement logic to handle multiple keys for nested data classes
4nalog Mar 8, 2023
50309ba
chore: fix update_npmversion (#709)
ursucarina Mar 7, 2023
d417ce5
Mapped Tasks not showing cache status correctly. (#712)
james-union Mar 7, 2023
e08f7e4
fix: cleanup, passthrough runtime variables (#710)
ursucarina Mar 7, 2023
19895c5
fix: update_npmversion (#713)
ursucarina Mar 7, 2023
e78a106
fix: fix sed makefile error (#714)
ursucarina Mar 8, 2023
c9700ba
FE: Update flyteconsole to Node 18 (#717)
james-union Mar 9, 2023
c37050b
chore: allow complex workflow names (#715)
ursucarina Mar 9, 2023
c36e80a
chore: show correct app version in info (#716)
ursucarina Mar 9, 2023
997ce2c
fix: left nav doesn't accurately update on workflow version page (#718)
ursucarina Mar 9, 2023
41a5562
feat: differentiate between cache disabled and cache put failure (#719)
james-union Mar 10, 2023
7035652
chore: fix formatting
4nalog Mar 10, 2023
0fab0d7
fix: add material-ui class name seed (#721)
ursucarina Mar 14, 2023
45c6386
The rendering of node status in a dynamic workflow is not functioning…
james-union Mar 15, 2023
d5a17a2
fix: backfill index on execution task logs (#725)
ursucarina Mar 16, 2023
7d2b69f
fix: release fail (#726)
ursucarina Mar 17, 2023
ddae902
Install deps directly in checks.yml (#728)
eapolinario Mar 21, 2023
5e252b4
fix: show correct i/o in details panel (#727)
ursucarina Mar 21, 2023
d4fd39e
chore: task observability (#720)
ursucarina Mar 22, 2023
16211bb
chore: fix contextual menu action buttons color (#730)
ursucarina Mar 23, 2023
26600f6
chore: add build:watch to all packages (#731)
ursucarina Mar 24, 2023
77932de
Add REJECT support for ApprovedCondition for GateNodes (#733)
james-union Mar 28, 2023
4107f72
gate node in dynamic task (#729)
james-union Mar 30, 2023
9423239
fix: comments
4nalog Mar 30, 2023
4f598e9
Merge branch 'master' of github.com:flyteorg/flyteconsole into soham/…
4nalog Mar 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const formatJson = data => {
keys.forEach(key => {
const item = data[`${key}`];
if (typeof item === 'object') {
data = { ...data, [key]: formatJson(item) };
data = { ...data, [key]: formatJson(item ?? {}) };
}
});

Expand Down Expand Up @@ -69,7 +69,10 @@ export const StructInput: React.FC<InputProps> = props => {
literalType?.metadata?.fields?.definitions?.structValue?.fields,
);

if (keys[0]) {
if (keys.length > 1) {
// If there are multiple keys, we can't render a form because of not supporting nested structs so render a text field
jsonFormRenderable = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to render a free-form text area in this case; they can paste in JSON?

} else if (keys[0]) {
parsedJson = protobufValueToPrimitive(
literalType.metadata.fields.definitions.structValue.fields[
`${keys[0]}`
Expand Down