Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert node version #704

Merged
merged 2 commits into from
Mar 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v2
with:
node-version: 18
node-version: 16
- uses: bahmutov/npm-install@v1
- name: Run tests and generate coverage
run: make test_unit_codecov
Expand All @@ -46,7 +46,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 18
node-version: 16
- uses: bahmutov/npm-install@v1
- name: Run linter
run: make lint
Expand All @@ -66,21 +66,15 @@ jobs:
release:
name: Generate Release
if: ${{ (github.event_name != 'pull_request') && (needs.extract_branch.outputs.branch == 'master') }}
needs:
[
unit_tests_with_coverage,
lint_project,
build_docker_image,
extract_branch,
]
needs: [unit_tests_with_coverage, lint_project, build_docker_image, extract_branch]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 18
node-version: 16
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Release
Expand Down Expand Up @@ -119,7 +113,7 @@ jobs:
push_docker_image:
name: Build & Push FlyteConsole Image
if: ${{ needs.check_for_tag.outputs.currentTag != '' }}
needs: [check_for_tag]
needs: [ check_for_tag ]
uses: flyteorg/flytetools/.github/workflows/publish.yml@master
with:
before-build: |
Expand Down
4 changes: 2 additions & 2 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 18.1.0
yarn 3.2.1
nodejs 16.18.0
yarn 3.2.1
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:experimental
FROM node:18.1.0 as builder
FROM node:16 as builder

LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteconsole

Expand Down