Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backfill index on execution task logs #725

Merged
merged 5 commits into from
Mar 16, 2023
Merged

fix: backfill index on execution task logs #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02f310b
chore: backfill index on execution task logs
ursucarina Mar 16, 2023
c87c42f
chore: add comments
ursucarina Mar 16, 2023
ff9c24f
chore: bump version
ursucarina Mar 16, 2023
a100fdb
chore: remove backfill
ursucarina Mar 16, 2023
c850890
chore: lint
ursucarina Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteorg/console",
"version": "0.0.13",
"version": "0.0.14",
"description": "Flyteconsole main app module",
"main": "./dist/index.js",
"module": "./lib/index.js",
Expand Down
4 changes: 3 additions & 1 deletion packages/console/src/components/Executions/TaskExecutionsList/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ export const getGroupedLogs = (
// if there is no log with active url, just create an item with externalId,
// for user to understand which array items are in this state
const newLogs =
item.logs.length > 0 ? item.logs : [{ name: item.externalId }];
item.logs.length > 0
? item.logs.map(l => ({ ...l, index: item.index }))
: [{ name: item.externalId, index: item.index }];
logsByPhase.set(
phase,
currentValue ? [...currentValue, ...newLogs] : [...newLogs],
Expand Down
8 changes: 6 additions & 2 deletions packages/console/src/components/common/MapTaskExecutionsList/TaskNameList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const TaskNameList = ({

return (
<>
{logs.map((log, taskIndex) => {
{logs.map((log, _taskIndex) => {
const taskLogName = getTaskLogName(
taskExecution.id.taskId.name,
log.name ?? '',
Expand All @@ -57,7 +57,11 @@ export const TaskNameList = ({
)?.cacheStatus;

const handleClick = () => {
onTaskSelected({ ...taskExecution, taskIndex });
// Use the resource's index instead of the log index
onTaskSelected({
...taskExecution,
taskIndex: (log as any).index || 0,
});
};

return (
Expand Down