-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top level masonry refactor #771
Conversation
3e93280
to
111c3f0
Compare
028d305
to
d3f6584
Compare
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
==========================================
- Coverage 66.90% 65.63% -1.28%
==========================================
Files 501 504 +3
Lines 12293 12505 +212
Branches 2262 2324 +62
==========================================
- Hits 8225 8208 -17
- Misses 4068 4297 +229
|
packages/console/src/components/Entities/VersionDetails/EntityVersionDetailsContainer.tsx
Outdated
Show resolved
Hide resolved
@@ -40,10 +42,12 @@ const useStyles = makeStyles<Theme, StyleProps>((theme: Theme) => ({ | |||
width: '100%', | |||
flex: '1', | |||
overflowY: 'scroll', | |||
padding: `0 ${theme.spacing(2)}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding: `0 ${theme.spacing(2)}`, | |
padding: theme.spacing(0, 2), |
packages/console/src/components/Entities/VersionDetails/EntityVersionDetailsContainer.tsx
Outdated
Show resolved
Hide resolved
packages/console/src/components/Entities/VersionDetails/EntityVersionDetailsContainer.tsx
Outdated
Show resolved
Hide resolved
packages/console/src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx
Show resolved
Hide resolved
packages/console/src/components/Executions/ExecutionDetails/Timeline/TimelineChart/utils.ts
Show resolved
Hide resolved
packages/console/src/components/Navigation/DefaultAppBarContent.tsx
Outdated
Show resolved
Hide resolved
packages/console/src/components/Navigation/DefaultAppBarContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left initial set of comments
da79f35
to
a7bcf4c
Compare
1807168
to
381d3be
Compare
Signed-off-by: Frank Flitton <[email protected]>
381d3be
to
cad695b
Compare
* chore: new nav bar Signed-off-by: Frank Flitton <[email protected]> * chore: navbar quick links Signed-off-by: Frank Flitton <[email protected]> * chore: task, workflow, launchplans Signed-off-by: Frank Flitton <[email protected]> * chore: remove unused import Signed-off-by: Frank Flitton <[email protected]> * chore: fixup navbar integration Signed-off-by: Frank Flitton <[email protected]> * chore: fix linter Signed-off-by: Frank Flitton <[email protected]> * chore: execution async value Signed-off-by: Frank Flitton <[email protected]> * chore: fix types build fail Signed-off-by: Frank Flitton <[email protected]> * chore: async self link Signed-off-by: Frank Flitton <[email protected]> * chore: add some exports Signed-off-by: Frank Flitton <[email protected]> * chore: change to names export Signed-off-by: Frank Flitton <[email protected]> * chore: spelling Signed-off-by: Carina Ursu <[email protected]> * chore: fix timestamps Signed-off-by: Carina Ursu <[email protected]> * chore: fix file upload type failure Signed-off-by: Frank Flitton <[email protected]> * chore: fix Executions title not updating Signed-off-by: Frank Flitton <[email protected]> * chore: remove depricated types file for dropzone Signed-off-by: Frank Flitton <[email protected]> * chore: fix execution launch plan self link Signed-off-by: Frank Flitton <[email protected]> * chore: pass custom component Signed-off-by: Frank Flitton <[email protected]> * chore: fix named entity cases Signed-off-by: Frank Flitton <[email protected]> * chore: different custom component style Signed-off-by: Frank Flitton <[email protected]> * chore: dynamic breadcrumb hook with event dispatch Signed-off-by: Frank Flitton <[email protected]> * chore: dynamic breadcrumb hook with event dispatch Signed-off-by: Frank Flitton <[email protected]> * chore: project and domains link to dashboard Signed-off-by: Frank Flitton <[email protected]> * chore: add localstorage setting Signed-off-by: Frank Flitton <[email protected]> * chore: get localstorage setting Signed-off-by: Frank Flitton <[email protected]> * chore: named entities self links Signed-off-by: Frank Flitton <[email protected]> * chore: spacing and scaffolding Signed-off-by: Frank Flitton <[email protected]> * chore: grey header color Signed-off-by: Frank Flitton <[email protected]> * fix/dropdown breadcrumbs (#799) fix: dropdown breadcrumbs Signed-off-by: Soham Parekh <[email protected]> Co-authored-by: Soham Parekh <[email protected]> * chore: global inject without emotion Signed-off-by: Frank Flitton <[email protected]> * chore: generate id Signed-off-by: Frank Flitton <[email protected]> * chore: initial unit tests Signed-off-by: Frank Flitton <[email protected]> * chore: fix incorrect localstore value Signed-off-by: Frank Flitton <[email protected]> * chore: named entities execution tests Signed-off-by: Frank Flitton <[email protected]> * chore: domain and project util tests Signed-off-by: Frank Flitton <[email protected]> * chore: fix execution list page title 404 ing Signed-off-by: Frank Flitton <[email protected]> * chore: fix swipe left to go back Signed-off-by: Frank Flitton <[email protected]> * chore: feature flag breadcrumb UI content Signed-off-by: Frank Flitton <[email protected]> * chore: set flags from url Signed-off-by: Frank Flitton <[email protected]> * chore: set flags from exxternal config Signed-off-by: Frank Flitton <[email protected]> * chore: set feature flags from env Signed-off-by: Frank Flitton <[email protected]> * chore: get flags from external env Signed-off-by: Frank Flitton <[email protected]> * chore: better docs from breadcrumbs interface Signed-off-by: Frank Flitton <[email protected]> --------- Signed-off-by: Frank Flitton <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Soham Parekh <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Co-authored-by: etdotal <[email protected]> Co-authored-by: Soham Parekh <[email protected]>
Changes addressed in a different commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to up the package versions for components, console and update website as well
Signed-off-by: Frank Flitton <[email protected]>
🎉 This PR is included in version 1.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Normalize how parts of pages are related in the DOM to allow for more reliable flex box behavior across screen sizes.
Added a top level layout component that can be substituted in the registry.
Grid
framework.Type
Are all requirements met?
Complete description
Refactored much of the top level code to separate the left nav from the router view. The UI is now flex box based with no top level components having fixed positioning.
Nav is now programmatically shown and hidden via a context state (with animation). The current approach is hardcoding routes with a wrapper.
During the refactor, it was discovered that the useProjects hook was using a cache system that would dump the payload when the route changed or a new project was selected. The components (left nav and main view) were remounted and created fresh caches on the route changes which masked the issue.
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA