Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix 404 due to bad state #797

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore: fix 404 due to bad state #797

merged 1 commit into from
Jul 19, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

When clicking 'View all projects' users get a bad local storage state that leads to 404's next time they land on the homepage

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Replaces the View all projects action to bypass the regular select-project path and directly navigate to the select-project page. Back-compat for users with corrupted states was added in the application router

Tracking Issue

fixes #3877

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team July 19, 2023 02:46
@ursucarina ursucarina removed the request for review from james-union July 19, 2023 04:03
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #797 (03afe00) into master (1da4d7a) will decrease coverage by 0.04%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   67.19%   67.16%   -0.04%     
==========================================
  Files         499      499              
  Lines       12207    12217      +10     
  Branches     2242     2247       +5     
==========================================
+ Hits         8203     8206       +3     
- Misses       4004     4011       +7     
Impacted Files Coverage Δ
...le/src/components/Navigation/NavLinkWithSearch.tsx 23.07% <ø> (ø)
...kages/console/src/components/Navigation/strings.ts 100.00% <ø> (ø)
packages/console/src/routes/ApplicationRouter.tsx 55.17% <0.00%> (-4.09%) ⬇️
...onsole/src/components/common/LocalStoreDefaults.ts 20.83% <20.00%> (-0.22%) ⬇️
...rc/components/Navigation/SearchableProjectList.tsx 93.54% <66.66%> (-2.89%) ⬇️

@jsonporter jsonporter merged commit a7ba08a into master Jul 19, 2023
@jsonporter jsonporter deleted the carina/404 branch July 19, 2023 16:39
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 404 error due to bad localStorage state
4 participants