Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map tasks should report caching status accurately #800

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

ursucarina
Copy link
Contributor

TL;DR

Map tasks do not correctly report their caching status

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Code updated to correctly track caching status on map tasks. UI updates to not allow cache status icons overflow to the right out of view

Before:

image

After

image

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@ursucarina ursucarina requested review from a team, FrankFlitton, jsonporter and 4nalog and removed request for a team July 21, 2023 18:25
Signed-off-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@3d3648e). Click here to learn what that means.
The diff coverage is 44.44%.

❗ Current head 45da744 differs from pull request most recent head 8d07a29. Consider uploading reports for the commit 8d07a29 to get more accurate results

@@            Coverage Diff            @@
##             master     #800   +/-   ##
=========================================
  Coverage          ?   67.06%           
=========================================
  Files             ?      499           
  Lines             ?    12238           
  Branches          ?     2251           
=========================================
  Hits              ?     8207           
  Misses            ?     4031           
  Partials          ?        0           
Impacted Files Coverage Δ
...tions/ExecutionDetails/NodeExecutionTabs/index.tsx 74.46% <ø> (ø)
...components/Executions/ExecutionDetails/strings.tsx 100.00% <ø> (ø)
.../src/components/Executions/nodeExecutionQueries.ts 39.37% <ø> (ø)
...ents/common/MapTaskExecutionsList/TaskNameList.tsx 89.28% <ø> (ø)
...components/Executions/NodeExecutionCacheStatus.tsx 70.58% <35.71%> (ø)
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 77.32% <66.66%> (ø)
...xecutionDetails/WorkflowNodeExecutionsProvider.tsx 88.65% <100.00%> (ø)

Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina merged commit 3eb0fa7 into master Jul 21, 2023
@ursucarina ursucarina deleted the carina/map branch July 21, 2023 23:33
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants