Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tasks status out of sync #802

Merged
merged 3 commits into from
Jul 26, 2023
Merged

fix: Tasks status out of sync #802

merged 3 commits into from
Jul 26, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

The task context panel doesn't correctly update its execution status

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

transformer worklow to dag is mutating state, which is causing certain parts of the ui to not pickup updates

@ursucarina ursucarina requested review from a team, FrankFlitton, jsonporter and 4nalog and removed request for a team July 25, 2023 22:47
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #802 (86b21ac) into master (16abb34) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 90.47%.

❗ Current head 86b21ac differs from pull request most recent head a69cb14. Consider uploading reports for the commit a69cb14 to get more accurate results

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   66.90%   66.90%   -0.01%     
==========================================
  Files         501      501              
  Lines       12293    12292       -1     
  Branches     2262     2261       -1     
==========================================
- Hits         8225     8224       -1     
  Misses       4068     4068              
Files Changed Coverage Δ
...s/ExecutionDetails/Timeline/TimelineChart/utils.ts 78.26% <50.00%> (ø)
...ions/contextProvider/NodeExecutionDetails/utils.ts 88.23% <75.00%> (-2.25%) ⬇️
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 77.45% <100.00%> (+0.13%) ⬆️
...xecutionDetails/WorkflowNodeExecutionsProvider.tsx 88.54% <100.00%> (ø)
...ponents/WorkflowGraph/transformerWorkflowToDag.tsx 48.76% <100.00%> (+0.64%) ⬆️

jsonporter
jsonporter previously approved these changes Jul 26, 2023
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina merged commit 8872536 into master Jul 26, 2023
@ursucarina ursucarina deleted the carina/refresh branch July 26, 2023 17:44
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants