Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test_coverage #803

Merged
merged 1 commit into from
Jul 26, 2023
Merged

chore: fix test_coverage #803

merged 1 commit into from
Jul 26, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Jul 26, 2023

TL;DR

Node max-old-space-size increase for test_coverage

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

test_coverage not running due to memory allocation

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina requested review from a team, FrankFlitton, jsonporter and 4nalog and removed request for a team July 26, 2023 18:03
@ursucarina ursucarina enabled auto-merge (squash) July 26, 2023 18:14
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #803 (3eabbb4) into master (16abb34) will decrease coverage by 3.54%.
Report is 2 commits behind head on master.
The diff coverage is 30.94%.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
- Coverage   66.90%   63.37%   -3.54%     
==========================================
  Files         501      527      +26     
  Lines       12293    13362    +1069     
  Branches     2262     2540     +278     
==========================================
+ Hits         8225     8468     +243     
- Misses       4068     4894     +826     
Files Changed Coverage Δ
packages/components/src/AppInfo/index.tsx 100.00% <ø> (ø)
...gurationProvider/ExternalConfigurationProvider.tsx 71.42% <ø> (ø)
packages/console/src/components/App/App.tsx 0.00% <0.00%> (ø)
...onsole/src/components/Breadcrumbs/viewAll/index.ts 0.00% <0.00%> (ø)
...ackages/console/src/components/Entities/strings.ts 100.00% <ø> (ø)
...console/src/components/Executions/Tables/styles.ts 100.00% <ø> (ø)
...console/src/components/Launch/LaunchForm/styles.ts 100.00% <ø> (ø)
...src/components/Navigation/DefaultAppBarContent.tsx 0.00% <0.00%> (ø)
...kages/console/src/components/Navigation/NavBar.tsx 0.00% <0.00%> (ø)
...le/src/components/Navigation/ProjectNavigation.tsx 0.00% <0.00%> (-36.85%) ⬇️
... and 59 more

... and 4 files with indirect coverage changes

@ursucarina ursucarina merged commit 36311eb into master Jul 26, 2023
@ursucarina ursucarina deleted the carina/tests branch July 26, 2023 18:21
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants