fix: specify node18, semantic release with exec and git plugins #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Flitton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 527 527
Lines 13362 13362
Branches 2540 2540
=======================================
Hits 8468 8468
Misses 4894 4894
|
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
FrankFlitton
changed the title
ursucarina
requested changes
Jul 28, 2023
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
ursucarina
requested changes
Jul 31, 2023
| const packageJson = JSON.parse(fs.readFileSync('./package.json', 'utf8')); | ||
| packageJson.version = version; | ||
|
|
||
| console.log('Writing new package.json contents.'); |
There was a problem hiding this comment.
is this dupe work of make update_npmversion (makefile ln 58)
There was a problem hiding this comment.
Not exactly.. this script doesn't update the root pacjage.json version which @semantic-release/npm would. I moved the functionality into a bash script inside the /scripts folder. The new script updates both root and /website package.json files when ran.
Signed-off-by: Frank Flitton <[email protected]>
ursucarina
approved these changes
Aug 1, 2023
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Unblock semantic release errors
Type
Are all requirements met?
Complete description
Bypass failing @semantic-release/npm failure release pipeline failure by recreating
npm versionswith @semantic-release/exec and @semantic-release/git.Updated other parts of the config to match latest versions of semantic-release docs.
Added missing deps for easier reproducibility and debugging.