Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: union value handling in launch form #812

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix: union value handling in launch form #812

merged 4 commits into from
Aug 8, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Union values in unexpected format cause the launch form to crash

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added smarter type detection around union type values

@ursucarina ursucarina requested review from a team, FrankFlitton, jsonporter and 4nalog and removed request for a team August 7, 2023 23:00
@ursucarina ursucarina changed the title Carina/union fix: union value handling in launch for Aug 7, 2023
@ursucarina ursucarina changed the title fix: union value handling in launch for fix: union value handling in launch form Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #812 (15d9bee) into master (8013196) will increase coverage by 0.02%.
The diff coverage is 66.00%.

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   63.37%   63.39%   +0.02%     
==========================================
  Files         527      527              
  Lines       13362    13390      +28     
  Branches     2540     2548       +8     
==========================================
+ Hits         8468     8489      +21     
- Misses       4894     4901       +7     
Files Changed Coverage Δ
...LaunchForm/LaunchFormComponents/CollectionList.tsx 22.22% <0.00%> (ø)
.../console/src/components/Launch/LaunchForm/types.ts 100.00% <ø> (ø)
...nch/LaunchForm/LaunchFormComponents/UnionInput.tsx 18.57% <16.66%> (-0.27%) ⬇️
...components/Launch/LaunchForm/inputHelpers/union.ts 48.43% <65.51%> (-1.57%) ⬇️
.../console/src/components/Launch/LaunchForm/utils.ts 68.42% <88.88%> (+3.85%) ⬆️
...sole/src/components/Launch/LaunchForm/constants.ts 100.00% <100.00%> (ø)
packages/console/src/models/Common/types.ts 100.00% <100.00%> (ø)

@ursucarina ursucarina merged commit 662429c into master Aug 8, 2023
@ursucarina ursucarina deleted the carina/union branch August 8, 2023 00:59
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants