feat: Expose caching status for NodeExecutions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 66.16% 66.70% +0.53%
==========================================
Files 368 370 +2
Lines 5894 5962 +68
Branches 910 930 +20
==========================================
+ Hits 3900 3977 +77
+ Misses 1994 1985 -9
Continue to review full report at Codecov.
|
kumare3
approved these changes
Aug 31, 2020
BobNisco
approved these changes
Aug 31, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Aug 31, 2020
# [0.10.0](http://github.com/lyft/flyteconsole/compare/v0.9.0...v0.10.0) (2020-08-31) ### Features * Expose caching status for NodeExecutions ([#91](http://github.com/lyft/flyteconsole/issues/91)) ([cb200bd](http://github.com/lyft/flyteconsole/commit/cb200bdd4d2708315a556e1e7d8b3d1df6af029b))
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#21
This change builds on the recent work to expose caching information about TaskNode executions. If taskNodeMetadata is found, we will render icons in the NodeExecutionsTable and icons+text in the DetailsPanel.
Note: For CACHE_MISS and CACHE_DISABLED, we will skip the icons in the table. The majority of node executions will probably be one of these two values, and I didn't want to clutter up the view with meaningless icons.
Details Panel for execution which used a cached value
Details Panel for execution whose result was written to cache
Details Panel for execution with cache disabled
Icons in the table