#patch bug fix for use in windows

[sakthi-tech4th]

Read then delete

• Make sure to use a concise title for the pull-request.
• Use #patch, #minor #majora or #none in the pull-request title to bump the corresponding version. Otherwise, the patch version
  will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2875

Follow-up issue

NA
OR
flyteorg/flyte#2875

[codecov]

Codecov Report

Merging #352 (be09409) into master (5a331a4) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head be09409 differs from pull request most recent head 9d46154. Consider uploading reports for the commit 9d46154 to get more accurate results

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage   69.62%   69.59%   -0.04%     
==========================================
  Files         140      140              
  Lines        4837     4844       +7     
==========================================
+ Hits         3368     3371       +3     
- Misses       1227     1229       +2     
- Partials      242      244       +2     

Flag	Coverage Δ
unittests	69.18% <50.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/register/register_util.go	77.73% <50.00%> (-0.48%)	⬇️
cmd/get/launch_plan.go	87.14% <0.00%> (ø)
cmd/update/launch_plan.go	71.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sakthi-tech4th]

shell date /t
is required when compiling on windows 11.
However, this raises a lint error.
So, reverting to original Makefile with comments

[sakthi-tech4th]

Fixed the issue

[sbrunk]

My co-worker just ran into this when he tried to register s.th. on a windows machine (pyflyte register doesn't work on windows either due to missing fork, see flyteorg/flyte#3451).

The PR looks solid to me. Can we merge this or do we need more verification that it works?

[wild-endeavor]

can we make this a logger?

[wild-endeavor]

Suggested change

/*tempDir, err := ioutil.TempDir("/tmp", "register")*/