Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Adding changes for project level matchable attr api #357

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

pmahindrakar-oss
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss commented Oct 4, 2022

Signed-off-by: pmahindrakar-oss [email protected]

TL;DR

  • GET (Application level default workflow execution config)
bin/flytectl get workflow-execution-config -p flytesnacks --attrFile a.yaml
warning file a.yaml will be overwritten [y/n]: y
wrote the config to file a.yaml%                                                                                                                                                                       cat a.yaml
domain: ""
max_parallelism: 25
project: flytesnacks
  • UPDATE (Add a new project level workflow execution config)
cat a.yaml 
domain: ""
max_parallelism: 26
project: flytesnacks
bin/flytectl update workflow-execution-config -p flytesnacks --attrFile a.yaml
Updated attributes from flytesnacks project
  • GET (Project level workflow execution config)
bin/flytectl get workflow-execution-config -p flytesnacks                     
{"project":"flytesnacks","domain":"","max_parallelism":26}
  • DELETE
bin/flytectl delete workflow-execution-config -p flytesnacks                  
Deleted matchable resources from flytesnacks project 
  • GET (Deleted the workflow level execution config but now return application level default)
bin/flytectl get workflow-execution-config -p flytesnacks    
{"project":"flytesnacks","domain":"","max_parallelism":25}

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2322

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #357 (36eacb4) into master (f454c31) will decrease coverage by 0.04%.
The diff coverage is 71.92%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   68.67%   68.62%   -0.05%     
==========================================
  Files         143      143              
  Lines        4935     4979      +44     
==========================================
+ Hits         3389     3417      +28     
- Misses       1299     1312      +13     
- Partials      247      250       +3     
Flag Coverage Δ
unittests 68.29% <70.90%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ext/deleter.go 100.00% <ø> (ø)
pkg/ext/fetcher.go 100.00% <ø> (ø)
pkg/ext/updater.go 100.00% <ø> (ø)
cmd/delete/matchable_attribute_util.go 54.16% <50.00%> (-12.50%) ⬇️
cmd/get/matchable_attribute_util.go 73.68% <50.00%> (-26.32%) ⬇️
cmd/update/matchable_attribute_util.go 56.00% <50.00%> (-12.43%) ⬇️
pkg/ext/attribute_match_fetcher.go 97.14% <90.90%> (-2.86%) ⬇️
cmd/get/get.go 100.00% <100.00%> (ø)
pkg/ext/attribute_match_updater.go 100.00% <100.00%> (ø)
pkg/ext/attribute_matcher_deleter.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmahindrakar-oss pmahindrakar-oss merged commit 77deca5 into master Nov 8, 2022
@pmahindrakar-oss pmahindrakar-oss deleted the project-attr branch November 8, 2022 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants