Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Added error data and abort data in get execution output #79

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: Prafulla Mahindrakar [email protected]

TL;DR

Sample get execution ooutput.

 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- ----------------------------------------------------------------------------------------------------------------- 
| NAME (79)            | LAUNCH PLAN NAME                          | TYPE        | PHASE     | STARTED                     | ELAPSED TIME   | ABORT DATA                                        | ERROR DATA                                                                                                      |
 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- ----------------------------------------------------------------------------------------------------------------- 
| f1ac227769dfc48c481f | core.flyte_basics.lp.child_workflow       | LAUNCH_PLAN | FAILED    | 2021-05-25T10:38:00.867112Z | 30.177727s     |                                                   | containers with unready status: [furvf51a-n0-0]|Error                                                           |
|                      |                                           |             |           |                             |                |                                                   | response from daemon: Minimum memory limit allowed is                                                           |
|                      |                                           |             |           |                             |                |                                                   | 6MB                                                                                                             |
 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- ----------------------------------------------------------------------------------------------------------------- 
| f6beffe2d562f463da23 | core.type_system.custom_objects.add       | TASK        | SUCCEEDED | 2021-05-28T14:13:10.678088Z | 7.685044s      |                                                   |                                                                                                                 |
 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- ----------------------------------------------------------------------------------------------------------------- 
| ffaz4xni             | morning_greeting                          | LAUNCH_PLAN | ABORTED   | 2021-05-25T10:38:01.616057Z | 29.253096s     | cascading abort as parent execution id            |                                                                                                                 |
|                      |                                           |             |           |                             |                | [f1ac227769dfc48c481f] aborted, reason [Some node |                                                                                                                 |
|                      |                                           |             |           |                             |                | execution failed, auto-abort.]                    |                                                                                                                 |
 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- ----------------------------------------------------------------------------------------------------------------- 
| fto1di2q             | morning_greeting                          | LAUNCH_PLAN | FAILED    | 2021-05-25T10:38:01.403746Z | 29.892845s     |                                                   | Workflow[flytectldemo:development:core.flyte_basics.lp.go_greet]                                                |
|                      |                                           |             |           |                             |                |                                                   | failed. RuntimeExecutionError: max number of system                                                             |
|                      |                                           |             |           |                             |                |                                                   | retry attempts [11/10] exhausted. Last known status                                                             |
|                      |                                           |             |           |                             |                |                                                   | message:                                                                                                        |
|                      |                                           |             |           |                             |                |                                                   | Workflow[flytectldemo:development:core.flyte_basics.lp.go_greet]                                                |
|                      |                                           |             |           |                             |                |                                                   | failed. CausedByError: Failed to propagate Abort for                                                            |
|                      |                                           |             |           |                             |                |                                                   | workflow. Error: 0: failed to record task event, as                                                             |
|                      |                                           |             |           |                             |                |                                                   | it already exists in terminal state. Event state:                                                               |
|                      |                                           |             |           |                             |                |                                                   | ABORTED: EventAlreadyInTerminalStateError: conflicting                                                          |
|                      |                                           |             |           |                             |                |                                                   | events; destination: ABORTED, caused by [rpc error:                                                             |
|                      |                                           |             |           |                             |                |                                                   | code = FailedPrecondition desc = invalid phase change                                                           |
|                      |                                           |             |           |                             |                |                                                   | from FAILED to ABORTED for task execution                                                                       |
|                      |                                           |             |           |                             |                |                                                   | {resource_type:TASK project:"flytectldemo"                                                                      |
|                      |                                           |             |           |                             |                |                                                   | domain:"development" name:"core.flyte_basics.lp.greet"                                                          |
|                      |                                           |             |           |                             |                |                                                   | version:"v1" node_id:"n0"                                                                                       |
|                      |                                           |             |           |                             |                |                                                   | execution_id:<project:"flytectldemo" domain:"development"                                                       |
|                      |                                           |             |           |                             |                |                                                   | name:"fto1di2q" > 0 {} [] 0}]                                                                                   |
 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- ----------------------------------------------------------------------------------------------------------------- 
| f1ojzhsi             | morning_greeting                          | LAUNCH_PLAN | FAILED    | 2021-05-25T10:38:02.333829Z | 28.244732s     | cascading abort as parent execution id            |                                                                                                                 |
|                      |                                           |             |           |                             |                | [f1ac227769dfc48c481f] aborted, reason [Some node |                                                                                                                 |
|                      |                                           |             |           |                             |                | execution failed, auto-abort.]                    |                                                                                                                 |
 ---------------------- ------------------------------------------- ------------- ----------- ----------------------------- ---------------- --------------------------------------------------- --------------------------------------------------------------------------------------------------------

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #79 (cce3238) into master (5cdc946) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files          89       89           
  Lines        1867     1867           
=======================================
  Hits         1163     1163           
  Misses        643      643           
  Partials       61       61           
Flag Coverage Δ
unittests 62.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/get/execution.go 92.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdc946...cce3238. Read the comment docs.

@kumare3 kumare3 merged commit cdc88ee into master Jun 3, 2021
@kumare3 kumare3 deleted the pmahindrakar/dump-execution-error branch June 3, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants