This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Update ArrayJob for Map task changes #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
changed the title
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
force-pushed
the
map-task-changes
branch
from
940fc02 to
e1d3a77
Compare
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
previously approved these changes
Feb 26, 2021
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
approved these changes
Feb 26, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Backwards compatible change for array jobs now that
container_arraytask types withtask_type_version > 0do not predetermine array job size. Instead they will pass in themin_success_ratiowhich can be used at runtime to determine themin_successesType
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#609
Follow-up issue
NA