This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Changed the String formatter from %s to %v and added more unit tests #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pmahindrakar-oss <[email protected]>
kumare3
reviewed
Mar 16, 2021
| @@ -483,11 +483,11 @@ func MakeLiteralForType(t *core.LiteralType, v interface{}) (*core.Literal, erro | |||
| } | |||
| case *core.LiteralType_Simple: | |||
There was a problem hiding this comment.
can we add a default here?
There was a problem hiding this comment.
Like the default should raise an error, saying unsupported type.
Also how do we handle Schema type and Blob type?
|
Can you link this to this issue - flyteorg/flyte#316? |
kumare3
pushed a commit
that referenced
this pull request
Mar 17, 2021
…122) Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Signed-off-by: Ketan Umare <[email protected]>
kumare3
added a commit
that referenced
this pull request
Mar 17, 2021
…lTypes (#120) * wip: more transformations Signed-off-by: Ketan Umare <[email protected]> * Changed the String formatter from %s to %v and added more unit tests (#122) Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Signed-off-by: Ketan Umare <[email protected]> * Added default condition for unsupported type while creating literal (#124) * Changed the String formatter from %s to %v and added more unit tests Signed-off-by: pmahindrakar-oss <[email protected]> * Added unsupported type default condition Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
…lTypes (#120) * wip: more transformations Signed-off-by: Ketan Umare <[email protected]> * Changed the String formatter from %s to %v and added more unit tests (#122) Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Signed-off-by: Ketan Umare <[email protected]> * Added default condition for unsupported type while creating literal (#124) * Changed the String formatter from %s to %v and added more unit tests Signed-off-by: pmahindrakar-oss <[email protected]> * Added unsupported type default condition Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pmahindrakar-oss [email protected]
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/