This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Additional execution properties as matchable entities. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pmahindrakar-oss
force-pushed
the
execution-parameters-matchable
branch
from
11e6268 to
828d867
Compare
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
pmahindrakar-oss
force-pushed
the
execution-parameters-matchable
branch
from
828d867 to
3466c8f
Compare
Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
changed the title
Signed-off-by: Prafulla Mahindrakar <[email protected]>
katrogan
commented
Mar 23, 2022
Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
approved these changes
Mar 24, 2022
|
Testing details available here flyteorg/flyteadmin#378 |
|
+1 although I guess I opened this PR so can't review hah |
yindia
approved these changes
Mar 25, 2022
|
Can we please add some description |
kumare3
approved these changes
Mar 25, 2022
|
Done. Thanks @kumare3 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* proposal Signed-off-by: Katrina Rogan <[email protected]> * comments Signed-off-by: Katrina Rogan <[email protected]> * Fixed the import and updated tooling Signed-off-by: Prafulla Mahindrakar <[email protected]> * Updating the golang version to 1.7 Signed-off-by: Prafulla Mahindrakar <[email protected]> * feedback Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan [email protected]
TL;DR
This changes add additional parameters to ExecutionConfig which are applied to a workflow in the form of annotations, labels, rawoutputDataConfig , security context which includes the identity to use for the running the user pod.
The order in which this matchable entities get used are as follows and appears 3rd
The IDL change is used in flyteadmin in the following way
flyteorg/flyteadmin#378
And from Flytectl
flyteorg/flytectl#298
Refer to the testing section of above two PR's
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
flyteorg/flyte#2070
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/