Go Linter Github action #283
Conversation
Signed-off-by: Yukesh Kumar <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
.github/workflows/linter.yml
Outdated
| stable: 'false' | ||
| go-version: '1.16.1' | ||
|
|
||
| - name: Lint |
There was a problem hiding this comment.
Thank you for opening a PR. I believe these checks are available in flyteorg/flytetools repo and should be referenced here as reusable workflows...
@evalsocket can you send links for examples from other repos?
There was a problem hiding this comment.
@TheYk98 @EngHabu We need to change lint workflow here https://github.com/flyteorg/flytetools/blob/master/.github/workflows/lint.yml
Currently we didn't migrated flyteidl changes, @TheYk98 it would be great if you can use re use able workflow here like https://github.com/flyteorg/flytectl/blob/master/.github/workflows/checks.yml#L19
There was a problem hiding this comment.
lemme check this mate
There was a problem hiding this comment.
changed wrt comment @evalsocket @EngHabu
Signed-off-by: Yukesh Kumar <[email protected]>
|
@TheYk98 amazing, Just have few comments After your changes now we have two workflow that run lint, Can you split the workflow https://github.com/flyteorg/flyteidl/blob/master/.github/workflows/verification.yml#L10-L29 ? Currently we have one workflow that we use for test & lint together. For example check flytectl https://github.com/flyteorg/flytectl/blob/master/.github/workflows/checks.yml#L19-L31 |
Hey @evalsocket got you . So can we just remove the existing step in the mentioned wf ? |
|
You can use same workflow file for defining both re useable WF, And remove old one |
Signed-off-by: Yukesh Kumar <[email protected]>
Signed-off-by: Yukesh Kumar <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=========================================
Coverage ? 74.77%
=========================================
Files ? 15
Lines ? 991
Branches ? 0
=========================================
Hits ? 741
Misses ? 218
Partials ? 32 Continue to review full report at Codecov.
|
|
Congrats on merging your first pull request! 🎉 |
* Usess re-usable linter Signed-off-by: Yukesh Kumar <[email protected]> Co-authored-by: Yuvraj <[email protected]>
Signed-off-by: Yukesh Kumar [email protected]
TL;DR
Adds go linter github actions
Type
Are all requirements met?
Complete description
Tracking Issue
#1874
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA