Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add interruptible override to execution #minor #287

Merged
merged 7 commits into from
May 2, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions gen/pb-go/flyteidl/admin/execution.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions gen/pb-go/flyteidl/admin/launch_plan.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions gen/pb-go/flyteidl/admin/matchable_resource.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions gen/pb-go/flyteidl/service/admin.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -3581,7 +3581,7 @@
"interruptible": {
"type": "boolean",
"format": "boolean",
"description": "Allows for the interruptible flag of a workflow to be overwritten for a single execution.\nOmitting this field uses the workflow's value as a default.\nAs we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper\naround the bool field. Since flyteadmin defines an interface requiring a unified interruptble override in several places, we cannot use\n\"oneof\" like in other places since that would generate incompatible Go types - instead, we're using one of the scalar type wrappers provided."
"description": "Allows for the interruptible flag of a workflow to be overwritten for a single execution.\nOmitting this field uses the launch plan's value as a default.\nAs we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper\naround the bool field."
}
},
"description": "An ExecutionSpec encompasses all data used to launch this execution. The Spec does not change over the lifetime\nof an execution as it progresses across phase changes."
Expand Down Expand Up @@ -3846,7 +3846,7 @@
"interruptible": {
"type": "boolean",
"format": "boolean",
"description": "Allows for the interruptible flag of a workflow to be overwritten for a single execution.\nOmitting this field uses the workflow's value as a default.\nAs we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper\naround the bool field. Since flyteadmin defines an interface requiring a unified interruptble override in several places, we cannot use\n\"oneof\" like in other places since that would generate incompatible Go types - instead, we're using one of the scalar type wrappers provided."
"description": "Allows for the interruptible flag of a workflow to be overwritten for a single execution.\nOmitting this field uses the launch plan's value as a default.\nAs we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper\naround the bool field."
}
},
"description": "User-provided launch plan definition and configuration values."
Expand Down Expand Up @@ -4937,7 +4937,7 @@
"interruptible": {
"type": "boolean",
"format": "boolean",
"description": "Allows for the interruptible flag of a workflow to be overwritten for a single execution.\nOmitting this field uses the workflow's value as a default.\nAs we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper\naround the bool field. Since flyteadmin defines an interface requiring a unified interruptble override in several places, we cannot use\n\"oneof\" like in other places since that would generate incompatible Go types - instead, we're using one of the scalar type wrappers provided."
"description": "Allows for the interruptible flag of a workflow to be overwritten for a single execution.\nOmitting this field uses the launch plan's value as a default.\nAs we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper\naround the bool field."
}
},
"description": "Adds defaults for customizable workflow-execution specifications and overrides."
Expand Down
21 changes: 6 additions & 15 deletions gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4029,13 +4029,10 @@ definitions:
type: "boolean"
format: "boolean"
description: "Allows for the interruptible flag of a workflow to be overwritten\
\ for a single execution.\nOmitting this field uses the workflow's value\
\ for a single execution.\nOmitting this field uses the launch plan's value\
\ as a default.\nAs we need to distinguish between the field not being provided\
\ and its default value \"false\", we have to use a wrapper\naround the\
\ bool field. Since flyteadmin defines an interface requiring a unified\
\ interruptble override in several places, we cannot use\n\"oneof\" like\
\ in other places since that would generate incompatible Go types - instead,\
\ we're using one of the scalar type wrappers provided."
\ bool field."
description: "An ExecutionSpec encompasses all data used to launch this execution.\
\ The Spec does not change over the lifetime\nof an execution as it progresses\
\ across phase changes."
Expand Down Expand Up @@ -6239,13 +6236,10 @@ definitions:
type: "boolean"
format: "boolean"
description: "Allows for the interruptible flag of a workflow to be overwritten\
\ for a single execution.\nOmitting this field uses the workflow's value\
\ for a single execution.\nOmitting this field uses the launch plan's value\
\ as a default.\nAs we need to distinguish between the field not being provided\
\ and its default value \"false\", we have to use a wrapper\naround the\
\ bool field. Since flyteadmin defines an interface requiring a unified\
\ interruptble override in several places, we cannot use\n\"oneof\" like\
\ in other places since that would generate incompatible Go types - instead,\
\ we're using one of the scalar type wrappers provided."
\ bool field."
description: "User-provided launch plan definition and configuration values."
example:
workflow_id:
Expand Down Expand Up @@ -28135,13 +28129,10 @@ definitions:
type: "boolean"
format: "boolean"
description: "Allows for the interruptible flag of a workflow to be overwritten\
\ for a single execution.\nOmitting this field uses the workflow's value\
\ for a single execution.\nOmitting this field uses the launch plan's value\
\ as a default.\nAs we need to distinguish between the field not being provided\
\ and its default value \"false\", we have to use a wrapper\naround the\
\ bool field. Since flyteadmin defines an interface requiring a unified\
\ interruptble override in several places, we cannot use\n\"oneof\" like\
\ in other places since that would generate incompatible Go types - instead,\
\ we're using one of the scalar type wrappers provided."
\ bool field."
description: "Adds defaults for customizable workflow-execution specifications\
\ and overrides."
example:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ type AdminExecutionSpec struct {
RawOutputDataConfig *AdminRawOutputDataConfig `json:"raw_output_data_config,omitempty"`
// Controls how to select an available cluster on which this execution should run.
ClusterAssignment *AdminClusterAssignment `json:"cluster_assignment,omitempty"`
// Allows for the interruptible flag of a workflow to be overwritten for a single execution. Omitting this field uses the workflow's value as a default. As we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper around the bool field. Since flyteadmin defines an interface requiring a unified interruptble override in several places, we cannot use \"oneof\" like in other places since that would generate incompatible Go types - instead, we're using one of the scalar type wrappers provided.
// Allows for the interruptible flag of a workflow to be overwritten for a single execution. Omitting this field uses the launch plan's value as a default. As we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper around the bool field.
Interruptible bool `json:"interruptible,omitempty"`
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ type AdminLaunchPlanSpec struct {
RawOutputDataConfig *AdminRawOutputDataConfig `json:"raw_output_data_config,omitempty"`
// Controls the maximum number of tasknodes that can be run in parallel for the entire workflow. This is useful to achieve fairness. Note: MapTasks are regarded as one unit, and parallelism/concurrency of MapTasks is independent from this.
MaxParallelism int32 `json:"max_parallelism,omitempty"`
// Allows for the interruptible flag of a workflow to be overwritten for a single execution. Omitting this field uses the workflow's value as a default. As we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper around the bool field. Since flyteadmin defines an interface requiring a unified interruptble override in several places, we cannot use \"oneof\" like in other places since that would generate incompatible Go types - instead, we're using one of the scalar type wrappers provided.
// Allows for the interruptible flag of a workflow to be overwritten for a single execution. Omitting this field uses the launch plan's value as a default. As we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper around the bool field.
Interruptible bool `json:"interruptible,omitempty"`
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ type AdminWorkflowExecutionConfig struct {
Labels *AdminLabels `json:"labels,omitempty"`
// Custom annotations to be applied to a triggered execution resource.
Annotations *AdminAnnotations `json:"annotations,omitempty"`
// Allows for the interruptible flag of a workflow to be overwritten for a single execution. Omitting this field uses the workflow's value as a default. As we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper around the bool field. Since flyteadmin defines an interface requiring a unified interruptble override in several places, we cannot use \"oneof\" like in other places since that would generate incompatible Go types - instead, we're using one of the scalar type wrappers provided.
// Allows for the interruptible flag of a workflow to be overwritten for a single execution. Omitting this field uses the launch plan's value as a default. As we need to distinguish between the field not being provided and its default value \"false\", we have to use a wrapper around the bool field.
Interruptible bool `json:"interruptible,omitempty"`
}
4 changes: 2 additions & 2 deletions gen/pb-go/flyteidl/service/openapi.go

Large diffs are not rendered by default.

Loading