Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Updates go version used in the pipeline #294

Merged
merged 9 commits into from
May 6, 2022
Merged

Conversation

yk-x-25
Copy link
Contributor

@yk-x-25 yk-x-25 commented Apr 30, 2022

TL;DR

Updates go versions to 1.18 for the pipeline

Type

  • Bug Fix
  • [ /] Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

changed the go version from 1.16 to 1.18

Tracking Issue

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #294 (9afd8a5) into master (e749b82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files          15       15           
  Lines         991      991           
=======================================
  Hits          741      741           
  Misses        218      218           
  Partials       32       32           
Flag Coverage Δ
unittests 75.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e749b82...9afd8a5. Read the comment docs.

@yindia yindia requested review from EngHabu and pmahindrakar-oss May 2, 2022 15:35
@EngHabu EngHabu enabled auto-merge (squash) May 6, 2022 02:03
@EngHabu EngHabu merged commit 654427e into flyteorg:master May 6, 2022
eapolinario pushed a commit that referenced this pull request Sep 8, 2023
* Adds linter for go code

Signed-off-by: Yukesh Kumar <[email protected]>

* Usess re-usable linter

Signed-off-by: Yukesh Kumar <[email protected]>

* changes wrt comment

Signed-off-by: Yukesh Kumar <[email protected]>

* changes wrt comments

Signed-off-by: Yukesh Kumar <[email protected]>

* updates go version in the yaml file

Signed-off-by: Yukesh Kumar <[email protected]>

Co-authored-by: Yuvraj <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants