This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
ClusterAssignment stores cluster pool for execution placement #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 18 18
Lines 1162 1162
=======================================
Hits 872 872
Misses 237 237
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
force-pushed
the
cluster-pools-assignment
branch
from
efc4b0a to
bf68762
Compare
iaroslav-ciupin
commented
Sep 19, 2022
|
|
||
| // A toleration selector is similar to that of an affinity but the only valid operators are EQUALS AND EXISTS. | ||
| repeated Selector selectors = 1; | ||
| string cluster_pool_name = 1; |
There was a problem hiding this comment.
@katrogan assured me that is not used , so I think there is no need to skip 1,2 positions
EngHabu
previously approved these changes
Sep 20, 2022
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
cluster-pools-assignment
branch
from
f40a947 to
13fc7b9
Compare
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
cluster-pools-assignment
branch
from
f8bbeaf to
5031b9c
Compare
2 tasks
iaroslav-ciupin
changed the title
Signed-off-by: Iaroslav Ciupin <[email protected]>
EngHabu
previously approved these changes
Sep 29, 2022
pmahindrakar-oss
previously approved these changes
Sep 30, 2022
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
dismissed stale reviews from pmahindrakar-oss and EngHabu
via
5581ca1
Signed-off-by: Iaroslav Ciupin <[email protected]>
pmahindrakar-oss
approved these changes
Sep 30, 2022
EngHabu
approved these changes
Sep 30, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Cluster Pool execution placement Signed-off-by: Haytham Abuelfutuh <[email protected]> * Make generate Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * make generate using new image Signed-off-by: Iaroslav Ciupin <[email protected]> * make generate again Signed-off-by: Iaroslav Ciupin <[email protected]> * make generate Signed-off-by: Iaroslav Ciupin <[email protected]> * make generate go1.18 Signed-off-by: Iaroslav Ciupin <[email protected]> * make generate go1.18.5 Signed-off-by: Iaroslav Ciupin <[email protected]> * backward-compatible ClusterAssignment Signed-off-by: Iaroslav Ciupin <[email protected]> * make generate Signed-off-by: Iaroslav Ciupin <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Iaroslav Ciupin <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Need a way to pass cluster pool for assigning newly created execution to it.
Type
Are all requirements met?