This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add Databricks config to Spark config #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 18 18
Lines 1362 1362
=======================================
Hits 996 996
Misses 315 315
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
protos/flyteidl/plugins/spark.proto
Outdated
| @@ -21,4 +21,8 @@ message SparkJob { | |||
| map<string, string> sparkConf = 4; | |||
| map<string, string> hadoopConf = 5; | |||
| string executorPath = 6; // Executor path for Python jobs. | |||
| // databricksConf is base64 encoded string which stores databricks job configuration. | |||
There was a problem hiding this comment.
why is the databricks one a b64 encoded string while the spark and hadoop conf's above just a map of str, str? Is the databricks one a binary object that needs to be encoded?
There was a problem hiding this comment.
Because it's nested dict. wait, I think I can use Struct here. Let me update it
wild-endeavor
previously approved these changes
Dec 9, 2022
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
approved these changes
Dec 15, 2022
eapolinario
approved these changes
Dec 16, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* databricks plugin Signed-off-by: Kevin Su <[email protected]> * update comment Signed-off-by: Kevin Su <[email protected]> * Use struct instead of string Signed-off-by: Kevin Su <[email protected]> * Add token Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * add instance name Signed-off-by: Kevin Su <[email protected]> * add instance name Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This config is used by the dbx plugin in propeller to submit the dbx job request.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3173