This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Added template configuration to task template #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 18 18
Lines 1377 1377
=======================================
Hits 1015 1015
Misses 311 311
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Jan 13, 2023
EngHabu
approved these changes
Jan 13, 2023
|
Why do we need this, why not use the one of |
|
@kumare3 e.g. for my usecases it boils down to setting some things like |
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
eapolinario
approved these changes
Jan 28, 2023
8 tasks
EngHabu
approved these changes
Jan 28, 2023
2 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* added template to task template Signed-off-by: Daniel Rammer <[email protected]> * updated docs Signed-off-by: Daniel Rammer <[email protected]> * updated pod_template_name location to TaskMetadata proto message Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds a template field to the
TaskTemplatewhich contains either aPodTemplatename or a marshaledPodTemplatestruct.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3123
Follow-up issue
NA