This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add prefix to data upload #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 75.92% 78.48% +2.55%
==========================================
Files 18 18
Lines 1458 1250 -208
==========================================
- Hits 1107 981 -126
+ Misses 294 212 -82
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Yee Hing Tong <[email protected]>
EngHabu
reviewed
Jun 15, 2023
8 tasks
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Jun 16, 2023
Comment on lines
+26
to
+29
| // The implementation in data proxy service will create the s3 location with some server side configured prefixes, | ||
| // and then: | ||
| // - project/domain/(a deterministic str representation of the content_md5)/filename (if present); OR | ||
| // - project/domain/filename_root (if present)/filename (if present). |
EngHabu
approved these changes
Jun 20, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This adds a field that will replace the content_md5-based string in Admin in the data upload link create request.
See flyteorg/flyteadmin#577 for use
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue