This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add interruptible field to TaskMetadata #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. @matthewphsmith: can you please take a look as well? |
wild-endeavor
previously approved these changes
Mar 6, 2020
wild-endeavor
approved these changes
Mar 7, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* add interruptible * upd comment * upd version * upd comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For interruptible we will populate it at the node level but require it be part of TaskMetadata for a user to set the value.
We are using
oneofinstead ofboolbecause otherwise we would be unable to distinguish between value being set by the user or defaulting to false.The logic of handling precedence will be done as part of flytepropeller.