This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add state to NamedEntity #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schottra
reviewed
Apr 3, 2020
protos/flyteidl/admin/common.proto
Outdated
| @@ -21,10 +21,23 @@ message NamedEntityIdentifier { | |||
| string name = 3; | |||
| } | |||
|
|
|||
| // The status of the named entity is used to control its visibility in the UI. | |||
| enum NamedEntityState { | |||
| // By default, all workflows are considered active and under development. | |||
There was a problem hiding this comment.
nit on this comment being specific to workflows
schottra
previously approved these changes
Apr 3, 2020
schottra
approved these changes
Apr 3, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change moves the state concept from individual workflows to named entities instead.
This change is backwards incompatible but reverts an endpoint that no one is calling in production.
Type
Are all requirements met?
Complete description
The console uses the list NamedEntityIdentifier endpoint rather than workflow one, so this should be updated for controlling visibility.
Tracking Issue
flyteorg/flyte#235
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/