This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feature; catalog metadata and caching status published in node events #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
previously approved these changes
Jun 11, 2020
Updated now |
kumare3
changed the title
wild-endeavor
previously approved these changes
Jul 7, 2020
| @@ -10,6 +10,7 @@ enum ResourceType { | |||
| TASK = 1; | |||
| WORKFLOW = 2; | |||
| LAUNCH_PLAN = 3; | |||
| DATASET = 4; | |||
There was a problem hiding this comment.
One of these things is not like the other. Can we at least add a comment explaining why there is something that looks different here? Also, could we create a GH issue if there isn't one to merge all the proto objects in data catalog https://github.com/lyft/datacatalog/blob/master/protos/idl/service.proto into this repo?
wild-endeavor
approved these changes
Jul 28, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
…#70) * Catalog store handling * Event proto updated * generated * merged * Dataset Identifier changed * Better model * Exposing TaskNodeMetadata with catalog information in the API * 0.17.38 * Comment * docs updated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Caching Information is currently not available in the UI or CLI. This hinders user productivity. This PR sets up the flow of data between propeller and admin. Once the data is published, next step would be to expose it through the API
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#138
Follow-up issue
flyteorg/flyte#71