Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Su <[email protected]>
  • Loading branch information
pingsutw committed Oct 22, 2021
1 parent 02c0586 commit 83d8fe9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions flytekit/remote/remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ def __init__(
self._labels = labels
self._annotations = annotations
self._raw_output_data_config = raw_output_data_config
self._grpc_credentials = grpc_credentials

# Save the file access object locally, but also make it available for use from the context.
FlyteContextManager.with_context(FlyteContextManager.current_context().with_file_access(file_access).build())
Expand Down Expand Up @@ -302,7 +301,6 @@ def with_overrides(
):
"""Create a copy of the remote object, overriding the specified attributes."""
new_remote = deepcopy(self)
# new_remote = FlyteRemote(self._flyte_admin_url, insecure, default_project, default_domain)
if default_project:
new_remote._default_project = default_project
if default_domain:
Expand Down Expand Up @@ -623,6 +621,8 @@ def _register_entity_if_not_exists(self, entity: WorkflowBase, resolved_identifi
raise NotImplementedError(f"We don't support registering this kind of entity: {node.flyte_entity}")
except FlyteEntityAlreadyExistsException:
logging.info(f"{entity.name} already exists")
except Exception as e:
logging.info(f"Failed to register Flyte entity {entity.name} with error v{e}")

####################
# Execute Entities #
Expand Down

0 comments on commit 83d8fe9

Please sign in to comment.