add password strip

Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Sep 14, 2022 · e443a50 · e443a50
1 parent 2ccaed7
commit e443a50
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/flytekit/configuration/file.py b/flytekit/configuration/file.py
@@ -291,4 +291,4 @@ def read_file_if_exists(filename: typing.Optional[str], encoding=None) -> typing
 
     filename = pathlib.Path(filename)
     logger.debug(f"Reading file contents from [{filename}] with current directory [{os.getcwd()}].")
-    return filename.read_text(encoding=encoding)
+    return filename.read_text(encoding=encoding).strip()
diff --git a/tests/flytekit/unit/configuration/test_internal.py b/tests/flytekit/unit/configuration/test_internal.py
@@ -42,6 +42,10 @@ def test_read_file_if_exists():
     assert read_file_if_exists(None) is None
     assert read_file_if_exists("") is None
 
+    bad_config_fn = os.path.join(os.path.dirname(os.path.realpath(__file__)), "configs/bad.config")
+    first_line = read_file_if_exists(filename=bad_config_fn)
+    assert not first_line.endswith("\n")
+
 
 def test_command():
     cfg = get_config_file(os.path.join(os.path.dirname(os.path.realpath(__file__)), "configs/good.config"))