Remove redundant error message and update exit strategy (#2374)

* fix(utils): Remove redundant error prints and update exit strategy Signed-off-by: Kevin Su <[email protected]> * fix test Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
flyteorg · Jul 25, 2024 · e99f994 · e99f994
1 parent e199113
commit e99f994
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/flytekit/clis/sdk_in_container/utils.py b/flytekit/clis/sdk_in_container/utils.py
@@ -76,7 +76,6 @@ def pretty_print_grpc_error(e: grpc.RpcError):
     if isinstance(e, grpc._channel._InactiveRpcError):  # noqa
         click.secho(f"RPC Failed, with Status: {e.code()}", fg="red", bold=True)
         click.secho(f"\tdetails: {e.details()}", fg="magenta", bold=True)
-        click.secho(f"\tDebug string {e.debug_error_string()}", dim=True)
     return
 
 
@@ -103,7 +102,6 @@ def pretty_print_exception(e: Exception):
         raise e
 
     if isinstance(e, FlyteException):
-        click.secho(f"Failed with Exception Code: {e._ERROR_CODE}", fg="red")  # noqa
         if isinstance(e, FlyteInvalidInputException):
             click.secho("Request rejected by the API, due to Invalid input.", fg="red")
         cause = e.__cause__
@@ -140,7 +138,7 @@ def invoke(self, ctx: click.Context) -> typing.Any:
                     raise e.with_traceback(None)
                 raise e
             pretty_print_exception(e)
-            raise SystemExit(e) from e
+            exit(1)
 
 
 def make_click_option_field(o: click.Option) -> Field:

diff --git a/tests/flytekit/unit/cli/pyflyte/test_register.py b/tests/flytekit/unit/cli/pyflyte/test_register.py
@@ -158,5 +158,4 @@ def test_non_fast_register_require_version(mock_client, mock_remote):
             f.close()
         result = runner.invoke(pyflyte.main, ["register", "--non-fast", "core3"])
         assert result.exit_code == 1
-        assert str(result.exception) == "Version is a required parameter in case --non-fast is specified."
         shutil.rmtree("core3")