-
Notifications
You must be signed in to change notification settings - Fork 305
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: Make sure default image can be found (#698)
Signed-off-by: Tim Bauer <[email protected]>
- Loading branch information
Showing
2 changed files
with
18 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import pytest | ||
|
||
from flytekit.core.context_manager import Image, ImageConfig | ||
from flytekit.core.python_auto_container import get_registerable_container_image | ||
|
||
|
||
@pytest.fixture | ||
def default_image_config(): | ||
default_image = Image(name="default", fqn="docker.io/xyz", tag="some-git-hash") | ||
return ImageConfig(default_image=default_image) | ||
|
||
|
||
def test_image_name_interpolation(default_image_config): | ||
img_to_interpolate = "{{.image.default.fqn}}:{{.image.default.version}}-special" | ||
img = get_registerable_container_image(img=img_to_interpolate, cfg=default_image_config) | ||
assert img == "docker.io/xyz:some-git-hash-special" |