fix tests ignore - pr into other pr (#1858)

Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Sep 28, 2023 · fc4656e · fc4656e
1 parent 6c6e652
commit fc4656e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/flytekit/models/interface.py b/flytekit/models/interface.py
@@ -72,8 +72,8 @@ def from_flyte_idl(cls, variable_proto) -> _interface_pb2.Variable:
         return cls(
             type=_types.LiteralType.from_flyte_idl(variable_proto.type),
             description=variable_proto.description,
-            artifact_partial_id=variable_proto.artifact_partial_id,
-            artifact_tag=variable_proto.artifact_tag,
+            artifact_partial_id=variable_proto.artifact_partial_id if variable_proto.HasField("artifact_partial_id") else None,
+            artifact_tag=variable_proto.artifact_tag if variable_proto.HasField("artifact_tag") else None,
         )
 
 

diff --git a/flytekit/models/launch_plan.py b/flytekit/models/launch_plan.py
@@ -71,7 +71,7 @@ def from_flyte_idl(cls, pb2_object):
             if pb2_object.HasField("schedule")
             else None,
             notifications=[_common.Notification.from_flyte_idl(n) for n in pb2_object.notifications],
-            launch_conditions=pb2_object.launch_conditions or None,
+            launch_conditions=pb2_object.launch_conditions if pb2_object.HasField("launch_conditions") else None,
         )