Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Hive query nodes #1

Merged
merged 13 commits into from
Sep 17, 2019
Merged

Single Hive query nodes #1

merged 13 commits into from
Sep 17, 2019

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Aug 21, 2019

Hive queries were originally bundled into one large dynamic node. This was a flawed design as it made the execution side of things far more complex. This now splits out each individual query into different nodes. See the corresponding change in the IDL flyteorg/flyteidl#3.

@wild-endeavor wild-endeavor changed the title Single hive query nodes Single Hive query nodes Aug 21, 2019
setup.py Outdated Show resolved Hide resolved
wild-endeavor added a commit to flyteorg/flyteidl that referenced this pull request Aug 30, 2019
This PR deprecates the QueryCollection field in the QuboleHiveJob custom plugin object. Please see the SDK PR for more information: flyteorg/flytekit#1
@wild-endeavor
Copy link
Contributor Author

@matthewphsmith - had to roll back the propeller change due to an issue haytham found in the updated plugins but the fix for it should be deployed tomorrow. After which this change can go out. Could you take another look please?

Thank you.

@wild-endeavor
Copy link
Contributor Author

ptal @matthewphsmith

@wild-endeavor
Copy link
Contributor Author

wait ptal doesn't do anything anymore.

@@ -1,4 +1,5 @@
from __future__ import absolute_import
import flytekit.plugins

__version__ = '0.1.9'
__version__ = '0.1.10'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make 0.2.0 so we mark this as a feature change.

matthewphsmith
matthewphsmith previously approved these changes Sep 17, 2019
Copy link
Collaborator

@matthewphsmith matthewphsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say make 0.2.0 for cleanliness.

@matthewphsmith matthewphsmith merged commit e2574d8 into master Sep 17, 2019
EngHabu added a commit that referenced this pull request Aug 18, 2020
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
mayitbeegh added a commit that referenced this pull request Sep 10, 2021
edgar-t added a commit to edgar-t/flytekit that referenced this pull request Sep 16, 2022
pingsutw pushed a commit to pingsutw/flyte-monorepo that referenced this pull request Apr 4, 2023
This PR deprecates the QueryCollection field in the QuboleHiveJob custom plugin object. Please see the SDK PR for more information: flyteorg/flytekit#1
ByronHsu added a commit to ByronHsu/flytekit that referenced this pull request May 29, 2023
eapolinario pushed a commit to flyteorg/flyte that referenced this pull request Sep 13, 2023
This PR deprecates the QueryCollection field in the QuboleHiveJob custom plugin object. Please see the SDK PR for more information: flyteorg/flytekit#1

Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants