Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read packages from environment variables #1002

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented May 13, 2022

TL;DR

Read packages from the FLYTE_SDK_WORKFLOW_PACKAGES environment variable for backwards compatibility.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

Slack reported issue.

@wild-endeavor wild-endeavor marked this pull request as ready for review May 13, 2022 21:47
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (09ce834) to head (ec36584).
Report is 1088 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files         255      255           
  Lines       24379    24379           
  Branches     2774     2774           
=======================================
  Hits        21065    21065           
  Misses       2842     2842           
  Partials      472      472           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 714136f into master May 13, 2022
eapolinario pushed a commit that referenced this pull request Jun 17, 2022
@eapolinario eapolinario mentioned this pull request Jun 17, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants