TypeTransformer for Numpy #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
Signed-off-by: Samhita Alla <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 86.39% 86.52% +0.12%
==========================================
Files 255 264 +9
Lines 24417 24713 +296
Branches 2776 2781 +5
==========================================
+ Hits 21096 21383 +287
- Misses 2849 2855 +6
- Partials 472 475 +3 ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
May 28, 2022
|
|
||
| # save numpy array to a file | ||
| # allow_pickle=False prevents numpy from trying to save object arrays (dtype=object) using pickle | ||
| np.save(file=local_path, arr=python_val, allow_pickle=False) |
There was a problem hiding this comment.
We can probably leverage typing.Annotated to offer an escape hatch in case the user wants to pickle object arrays (with all the risks/caveats). Not for this PR though.
eapolinario
pushed a commit
that referenced
this pull request
Jun 17, 2022
* precommit Signed-off-by: Samhita Alla <[email protected]> * fix failing tests Signed-off-by: Samhita Alla <[email protected]>
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samhita Alla [email protected]
TL;DR
This PR adds support for
numpy.ndarrayas a native Flyte type.One caveat: object Numpy arrays cannot be serialized and unserialized.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2544
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/