Fix wrong version help string in pyflyte register
#1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg91
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
fg91
changed the title
pyflyte register
kumare3
previously approved these changes
Jun 5, 2022
|
@fg91 can you dco sign off? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 86.50% 86.50%
=======================================
Files 267 267
Lines 24795 24795
Branches 2787 2787
=======================================
Hits 21450 21450
Misses 2868 2868
Partials 477 477 ☔ View full report in Codecov by Sentry. |
The `click.option("-v", "--version", ..)` currently has the help string from `@click.option("--service-account", ...)`.
Signed-off-by: fg91 <[email protected]>
kumare3
approved these changes
Jun 6, 2022
pingsutw
approved these changes
Jun 6, 2022
|
@pingsutw could you please merge? |
|
Congrats on merging your first pull request! 🎉 |
|
Merged, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The
click.option("-v", "--version", ..)currently has the help string from@click.option("--service-account", ...).Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/