Fix read authorization_metadata_key from public_client_config in _refresh_credentials_from_command

[sonjaer]

TL;DR

FLYTE_CREDENTIALS_AUTHORIZATION_METADATA_KEY environment variable was removed in this PR #858 in favor of reading the authorization metadata key from Admin.

There was a miss in the PR where the _refresh_credentials_from_command did not switch to get the authorization key from self.public_client_config.authorization_metadata_key but instead used the default value authorization.

Spotify uses flyte-authorization so we received an error about calls being UNAUTHENTICATED since the header name didn't correspond to the one expected by admin.

This PR adds support for reading authorization_metadata_key from public_client_config in _refresh_credentials_from_command

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (14b3a4c) to head (af9b033).
Report is 1057 commits behind head on master.

Files	Patch %	Lines
flytekit/clients/raw.py	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   86.51%   86.52%   +0.01%     
==========================================
  Files         268      268              
  Lines       24864    24893      +29     
  Branches     2799     2803       +4     
==========================================
+ Hits        21510    21539      +29     
+ Misses       2877     2875       -2     
- Partials      477      479       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

Thanks for this fix, the change to pass the authorization key in the case of external commands was missing.

[sonjaer]

@eapolinario what takes precedence from config, env and passing a flag?

[eapolinario]

@eapolinario what takes precedence from config, env and passing a flag?

flyte-cli rules are a bit more complicated, but in general, for configuration settings, environment variables take precedence over config data, with the exception of the host and insecure flags.