Add condition to generation of dynamic job spec #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please see the issue for a proper description.
Type
Are all requirements met?
Complete description
If a launch plan/subworkflow node does not have outputs, currently there is no dynamic job spec created. This was the main issue this PR is meant to address.
Also discovered that if the workflow/launchplan yielded in a dynamic node does not have outputs, but does have inputs, those inputs would not be generated. This was from improper indentation from the first time this code was created.
This code needs to be cleaned up... a lot. See the follow-up issue.
Tracking Issue
flyteorg/flyte#282
Follow up issue
flyteorg/flyte#226