refreshing examples and to_html() method #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: - examples on our README were not using the latest whylogs.core.constraints.factories the same way as on flytesnacks. - WhylogsDatasetProfileTransformer.to_html() now returns a ProfileSummary HTML string Signed-off-by: murilommen <[email protected]>
murilommen
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
=======================================
Coverage 68.53% 68.53%
=======================================
Files 288 288
Lines 26197 26197
Branches 2924 2924
=======================================
Hits 17954 17954
Misses 7765 7765
Partials 478 478 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: murilommen <[email protected]>
eapolinario
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Type
Are all requirements met?
Complete description
Make our README.md in line with whylogs' examples page and also flytenacks'
Tracking Issue
NA
Follow-up issue
NA