-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass cluster pool when creating executions #1208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
iaroslav-ciupin
force-pushed
the
create-execution-on-cluster-pool
branch
2 times, most recently
from
September 30, 2022 17:54
8e6b944
to
fe5b6f1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
+ Coverage 20.11% 20.13% +0.01%
==========================================
Files 337 337
Lines 32409 32427 +18
Branches 5854 5857 +3
==========================================
+ Hits 6520 6530 +10
- Misses 25723 25731 +8
Partials 166 166
☔ View full report in Codecov by Sentry. |
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
create-execution-on-cluster-pool
branch
2 times, most recently
from
September 19, 2023 17:40
132c2cc
to
9c3bcee
Compare
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
create-execution-on-cluster-pool
branch
from
September 19, 2023 17:47
9c3bcee
to
62804a9
Compare
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
create-execution-on-cluster-pool
branch
from
September 20, 2023 14:31
58747d6
to
80720d0
Compare
iaroslav-ciupin
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
September 20, 2023 14:49
pingsutw
reviewed
Sep 20, 2023
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
create-execution-on-cluster-pool
branch
from
September 21, 2023 07:02
4f97c87
to
43230d9
Compare
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
Signed-off-by: Iaroslav Ciupin <[email protected]>
pingsutw
approved these changes
Sep 22, 2023
Congrats on merging your first pull request! 🎉 |
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
* Pass cluster pool when creating executions Signed-off-by: Future Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
pyflyte run --remote --cluster-pool gpu my_wf.py
Type
Are all requirements met?