ContainerTask fix to read base env vars properly from compilation settings #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario and
pingsutw
as code owners
eapolinario
approved these changes
Oct 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
=======================================
Coverage 68.57% 68.57%
=======================================
Files 288 288
Lines 26224 26225 +1
Branches 2929 2929
=======================================
+ Hits 17984 17985 +1
Misses 7762 7762
Partials 478 478
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Bug in container task that wasn't being hit unless user specifies an additional env var map in the task.
Type
Are all requirements met?
Complete description
Fix npe.
Tracking Issue
User reported issue:
https://discuss.flyte.org/t/2749411/what-s-your-gh-handle-U03KEF8H6FR