Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf versions in requirements #1228

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Conversation

eapolinario
Copy link
Collaborator

Signed-off-by: Eduardo Apolinario [email protected]

TL;DR

Bump protobuf versions to protect against https://security.snyk.io/vuln/SNYK-PYTHON-PROTOBUF-3031740

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1228 (3ae1510) into master (605639a) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   68.46%   68.58%   +0.12%     
==========================================
  Files         288      288              
  Lines       26232    26232              
  Branches     2923     2929       +6     
==========================================
+ Hits        17959    17992      +33     
+ Misses       7779     7762      -17     
+ Partials      494      478      -16     
Impacted Files Coverage Δ
tests/flytekit/unit/core/test_type_hints.py 96.23% <0.00%> (+0.08%) ⬆️
flytekit/extras/tasks/shell.py 77.71% <0.00%> (+1.14%) ⬆️
tests/flytekit/unit/tools/test_ignore.py 100.00% <0.00%> (+1.37%) ⬆️
flytekit/extras/persistence/http.py 24.48% <0.00%> (+2.04%) ⬆️
tests/flytekit/unit/extras/tasks/test_shell.py 100.00% <0.00%> (+19.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants