Stable local cache keys even in the case of nested dictionaries #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
+ Coverage 68.64% 68.66% +0.01%
==========================================
Files 288 288
Lines 26301 26303 +2
Branches 2937 2936 -1
==========================================
+ Hits 18055 18060 +5
+ Misses 7767 7764 -3
Partials 479 479
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pingsutw
approved these changes
Oct 13, 2022
VPraharsha03
pushed a commit
to VPraharsha03/flytekit
that referenced
this pull request
Oct 29, 2022
Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Vivek Praharsha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario [email protected]
TL;DR
Generate local cache keys by using protobuf's stable representation + joblib hashing
Type
Are all requirements met?
Complete description
In #1126 we started using joblib and a custom Hasher to produce cache keys. That change handled the case of top-level dictionaries, but not nested dictionaries.
This PR takes a different approach. We leverage the stable representation produced by the protobuf library and use that string as input (instead of a more complex object) as an input to
joblib.hash(which generates fixed-length strings).Tracking Issue
flyteorg/flyte#2924
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/