Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT Plugin Api reference #1232

Merged
merged 1 commit into from
Oct 13, 2022
Merged

DBT Plugin Api reference #1232

merged 1 commit into from
Oct 13, 2022

Conversation

arpitbhardwaj
Copy link
Contributor

@arpitbhardwaj arpitbhardwaj commented Oct 12, 2022 •
edited by samhita-alla
Loading

Update the plugin docs to include the dbt plugin module.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Verified with the local testing for docs using "make html"

Tracking Issue

Fixes flyteorg/flyte#2966

Follow-up issue

NA

@welcome
Copy link

welcome bot commented Oct 12, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@samhita-alla
Copy link
Contributor

@arpitbhardwaj, thanks for creating the PR! Can you sign off your commits, please?

@samhita-alla
Copy link
Contributor

Can you also include dataclasses present in https://github.com/flyteorg/flytekit/blob/master/plugins/flytekit-dbt/flytekitplugins/dbt/schema.py?

@arpitbhardwaj
Copy link
Contributor Author

@samhita-alla Added classes from schema.py as well and also signed-off the commit.

pingsutw
pingsutw previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @arpitbhardwaj. cc @eapolinario mind taking a look?

@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

Merging #1232 (80788ae) into master (b1dbab9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1232   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         288      288           
  Lines       26321    26321           
  Branches     2940     2940           
=======================================
  Hits        18074    18074           
  Misses       7769     7769           
  Partials      478      478

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pingsutw
Copy link
Member

@arpitbhardwaj need to fix the lint error by running make fmt

@eapolinario
Copy link
Collaborator

Change looks good, we need to fix the linting errors though.

@arpitbhardwaj
Copy link
Contributor Author

@pingsutw @eapolinario Fixed the linting errors.

@eapolinario eapolinario merged commit ab9aa65 into flyteorg:master Oct 13, 2022
@welcome
Copy link

welcome bot commented Oct 13, 2022

Congrats on merging your first pull request! 🎉

VPraharsha03 pushed a commit to VPraharsha03/flytekit that referenced this pull request Oct 29, 2022
@arpitbhardwaj
DBT plugin api reference doc update (flyteorg#1232)
c5e1dd6 
Signed-off-by: arpitbhardwaj <[email protected]>

Signed-off-by: arpitbhardwaj <[email protected]>
Signed-off-by: Vivek Praharsha <[email protected]>
kiliangojek pushed a commit to kiliangojek/flytekit that referenced this pull request Nov 15, 2022
@arpitbhardwaj
DBT plugin api reference doc update (flyteorg#1232)
74c6912 
Signed-off-by: arpitbhardwaj <[email protected]>

Signed-off-by: arpitbhardwaj <[email protected]>
Signed-off-by: Kilian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eapolinario eapolinario eapolinario approved these changes

@pingsutw pingsutw pingsutw left review comments

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Add DBT plugin API reference
4 participants
@arpitbhardwaj @samhita-alla @pingsutw @eapolinario