-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeTransformer for TensorFlow tensor #1243
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Could we move these files to flytekit/extras/tensorflow/tensor
? because we have another pr adding the TensorFlow model transformer to this directory.
btw, we need a test for TensorflowTensorTransformer
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
+ Coverage 68.63% 68.74% +0.11%
==========================================
Files 288 292 +4
Lines 26279 26462 +183
Branches 2935 2492 -443
==========================================
+ Hits 18036 18192 +156
- Misses 7764 7789 +25
- Partials 479 481 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I've tried adding I've also tried what was suggested here in this comment of PR#1240, but unfortunately none of them worked out and I'd to additionally pin the version of protobuf to @pingsutw Would pinning the protobuf version be a right fix for this issue? There are two choices, either we'd have to pin the protobuf version if we want to have the latest TensorFlow 2.10 or pin the tensorflow version to 2.8.1 instead |
bf95827
to
843f4c9
Compare
@pingsutw Added tests, please review them, I'll be adding the documentation very soon |
@VPraharsha03 let me know after you work on our suggestions. |
Copied my feedback from the Slack thread:
|
@samhita-alla Done with the changes, still have to fix linting issues |
I'm sorry, I'd messed up badly while committing, I've opened a new PR here |
This PR adds support for
tf.Tensor
as a native flyte typeType
Are all requirements met?
Complete description
tf.Tensor
inflytekit/extras/tensorflow/tensor/tensor.py
Note : I'm working on the tests and will be soon adding them.Done.Tracking Issue
flyteorg/flyte#2569
Follow-up issue
NA