Install sklearn in default image and unify dockerfiles #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
eapolinario
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 288 288
Lines 26323 26333 +10
Branches 2939 2942 +3
=======================================
+ Hits 18079 18087 +8
- Misses 7766 7768 +2
Partials 478 478
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cosmicBboy
previously approved these changes
Oct 19, 2022
pingsutw
previously approved these changes
Oct 19, 2022
Signed-off-by: Eduardo Apolinario <[email protected]>
cosmicBboy
approved these changes
Oct 19, 2022
pingsutw
approved these changes
Oct 19, 2022
VPraharsha03
pushed a commit
to VPraharsha03/flytekit
that referenced
this pull request
Oct 23, 2022
* Single dockerfile Signed-off-by: Eduardo Apolinario <[email protected]> * Install sklearn in the image Signed-off-by: Eduardo Apolinario <[email protected]> * Install deck plugin Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Vivek Praharsha <[email protected]>
VPraharsha03
pushed a commit
to VPraharsha03/flytekit
that referenced
this pull request
Oct 29, 2022
* Single dockerfile Signed-off-by: Eduardo Apolinario <[email protected]> * Install sklearn in the image Signed-off-by: Eduardo Apolinario <[email protected]> * Install deck plugin Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Vivek Praharsha <[email protected]>
kiliangojek
pushed a commit
to kiliangojek/flytekit
that referenced
this pull request
Nov 15, 2022
* Single dockerfile Signed-off-by: Eduardo Apolinario <[email protected]> * Install sklearn in the image Signed-off-by: Eduardo Apolinario <[email protected]> * Install deck plugin Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Kilian <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Install sklearn in the default images
Type
Are all requirements met?
Complete description
I also took the time to decrease duplication in the dockerfiles. Now we only have a single dockerfile and we take the python version as an argument.
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/