Override node name #1344
Override node name #1344
Conversation
Signed-off-by: Hongxin Liang <[email protected]>
honnix
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
| @@ -401,3 +397,24 @@ def my_wf(a: str): | |||
| _resources_models.ResourceEntry(_resources_models.ResourceName.CPU, "1"), | |||
| _resources_models.ResourceEntry(_resources_models.ResourceName.MEMORY, "100"), | |||
| ] | |||
|
|
|||
|
|
|||
| def test_name_override(): | |||
| @@ -87,6 +87,7 @@ def empty_wf2(): | |||
| wf_spec = get_serializable(OrderedDict(), serialization_settings, empty_wf2) | |||
| assert wf_spec.template.nodes[0].upstream_node_ids[0] == "n1" | |||
| assert wf_spec.template.nodes[0].id == "n0" | |||
| assert wf_spec.template.nodes[0].metadata.name == "t2" | |||
|
|
It's not related to your change. I'm actively investigating this. |
@eapolinario Thanks for heads-up! |
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 68.85% 68.79% -0.07%
==========================================
Files 287 287
Lines 26453 26462 +9
Branches 2497 2498 +1
==========================================
- Hits 18215 18204 -11
- Misses 7750 7773 +23
+ Partials 488 485 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hmm I guess I was using a different black version. I will try to fix that. |
Signed-off-by: Yee Hing Tong <[email protected]>
|
@honnix i just ran make fmt |
honnix
force-pushed
the
override-node-name
branch
from
65a5ef0 to
dfd3487
Compare
|
Sorry I missed the message. I reverted my commits. |
Thanks. The pre-commit thing. Nice! |
|
Thank you for merging this. Now I need your help to figure out why the UI is not consistent. I have attached some screenshots to help. Graph and Timeline are both good, but not Nodes. It feels like Nodes always takes the last part of the full name.
|
Signed-off-by: Hongxin Liang [email protected]
TL;DR
Override node name.
Type
Are all requirements met?
Complete description
More details are captured in #3092.
I tested this on our setup. Everything seems to work fine, except the
Nodestab of the execution detail view. WhileGraphandTimelineboth show the overridden node name,Nodestab still shows the original task name.Also note that many changes were made by
black.Tracking Issue
flyteorg/flyte#3092
Follow-up issue
NA