Skip copying files to the remote path if the directory is empty #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 68.94% 69.04% +0.10%
==========================================
Files 291 291
Lines 26656 26699 +43
Branches 2508 2514 +6
==========================================
+ Hits 18377 18435 +58
+ Misses 7789 7772 -17
- Partials 490 492 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
reviewed
Nov 25, 2022
| try: | ||
| lpaths = lfs.expand_path(from_path, recursive=recursive) | ||
| except FileNotFoundError: | ||
| # In some cases, there is no file in the original directory, so we just skip copying the file to the remote path |
There was a problem hiding this comment.
can you add a debug log here mentioning that the file does not exist?
There was a problem hiding this comment.
yeah let's do that @pingsutw
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
test_union_typefailed if the fsspec is installed because the fsspec will fail to copy the directory to the remote path if the directory is empty.In some cases, flyte schema could be empty if people forget to use
flyteSchema.open().writeto write the data to local pathType
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA