Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: vaex plugin #1356

Merged
merged 1 commit into from
Nov 29, 2022
Merged

bug fix: vaex plugin #1356

merged 1 commit into from
Nov 29, 2022

Conversation

samhita-alla
Copy link
Contributor

@samhita-alla samhita-alla commented Nov 29, 2022

Signed-off-by: Samhita Alla [email protected]

TL;DR

This PR:

  • Replaces metadata=StructuredDatasetMetadata(structured_dataset_type=StructuredDatasetType(structured_dataset_type)) with metadata=StructuredDatasetMetadata(structured_dataset_type=structured_dataset_type) (thanks, @pingsutw!)
  • Fixes a misspelled decoder
  • Adds plugin API reference

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Samhita Alla <[email protected]>
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1356 (bafbc30) into master (9e40690) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   68.86%   69.04%   +0.18%     
==========================================
  Files         287      291       +4     
  Lines       26446    26697     +251     
  Branches     2499     2514      +15     
==========================================
+ Hits        18212    18433     +221     
- Misses       7749     7772      +23     
- Partials      485      492       +7     
Impacted Files Coverage Δ
flytekit/tools/fast_registration.py 81.53% <0.00%> (-4.62%) ⬇️
flytekit/remote/remote.py 40.51% <0.00%> (-1.05%) ⬇️
flytekit/configuration/__init__.py 36.87% <0.00%> (-0.67%) ⬇️
flytekit/models/core/identifier.py 38.70% <0.00%> (-0.62%) ⬇️
flytekit/models/literals.py 40.28% <0.00%> (-0.58%) ⬇️
flytekit/tools/serialize_helpers.py 92.53% <0.00%> (-0.22%) ⬇️
tests/flytekit/unit/core/test_node_creation.py 95.60% <0.00%> (-0.20%) ⬇️
tests/flytekit/unit/core/test_promise.py 89.18% <0.00%> (-0.10%) ⬇️
flytekit/clis/helpers.py 94.59% <0.00%> (ø)
flytekit/core/base_task.py 46.88% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pingsutw pingsutw merged commit 46abe91 into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants